search

signalapp / Signal-Desktop

A private messenger for Windows, macOS, and Linux.
https://signal.org/download
GNU Affero General Public License v3.0
14.69k stars 2.68k forks source link

Scrollbars, file menu bar and titlebar too bright when the dark theme is chosen #2592

Open lakozapamcenje opened 6 years ago

lakozapamcenje commented 6 years ago

Contrast between background (black) and scrollbars and titlebars is very distracting. It's only an issue when the chosen theme is dark. Please fix this - if the theme is dark, scrollbar should be also dark, black or grey, but certainly not white.

new-1

h1dden-da3m0n commented 6 years ago

i agree with you, especialy since the old dark mode WAS MUCH SUPERIOUR to this new one. it looked more like IntelliJ Darkular and now it is just black and unpleasant. But the point is the old design had this handled as it did not use the native scrolebars but actualy used "dark" ones

emptyflask commented 6 years ago

FWIW, here it is looking particularly bad on MacOS at the width I usually keep it.

screen shot 2018-08-03 at 11 15 32 am

lakozapamcenje commented 6 years ago

Now please excuse my ignorance, but I don't understand the current status of this complaint - is it a bug that is going to be fixed in some of the upcoming releases, or it's not considered a bug?

mrckndt commented 6 years ago

It's the same for Linux (in my case Fedora). The desktop app doesn't switch to the desktop GTK theme an therefore i'm getting an light menubar and a light filechooser. In Mattermost Desktop (another Electron app) it inherits the style colors from the OS.

scottnonnenberg-signal commented 6 years ago

The scrollbars are now fixed in the dark theme. But it will be a substantial amount of additional work to change the title bar of the app to dark colors on all platforms. We would certainly welcome folks in the community to help out with this!

jsatk commented 5 years ago

I believe Signal is an Electron app. Spotify & Slack are both electron apps and respect the macOS theme for the menu bar. I don't know much about developing apps on macOS, but if someone was to dig into how to get the title bar to respect the os theme those apps might offer some insight since I believe they're using the same framework(s).

bbb651 commented 3 years ago

I know this is an old issue but I think it's pretty impotent, this has become a lot more common with electron applications, and electron has official docs on how to achieve this. If I manage to set up the development environment I'll try to make a pull request.

buchwasa commented 3 years ago

I know this is an old issue but I think it's pretty impotent, this has become a lot more common with electron applications, and electron has official docs on how to achieve this. If I manage to set up the development environment I'll try to make a pull request.

There's also a library that can easily achieve this: https://www.npmjs.com/package/custom-electron-titlebar