signalwire / signalwire-js

MIT License

18 stars 15 forks source link

Throw error from `startScreenShare` method if permission is denied #1120

Closed iAmmar7 closed 1 month ago

iAmmar7 commented 1 month ago

Description

The startScreenShare method is now going to throw the permission denied error if the user does not allow getDisplayMedia permissions.

Additional work:

Fix playground with reattach
Expose the StartScreenShareOptions type

Type of change

[ ] Internal refactoring
[x] Bug fix (bugfix - non-breaking)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 0bbde020c07181a8b7ed82eabac6509f3d95ecb7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | -------------- | ----- | | @signalwire/js | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR