signalwire / signalwire-js

MIT License

18 stars 15 forks source link

CF SDK: Negotiate callee media based on the Remote SDP #1125

Open iAmmar7 opened 1 month ago

iAmmar7 commented 1 month ago

Description

The CF SDK handles the Caller user media based on the destination address channel. This PR will now handle the Callee user media based on the incoming/remote SDP.

Additional changes;

Set the outgoing video negotiation based on the destination address channel but give more priority to user-passed params.
Remove handling media based on the remote SDP part from the generic getMediaConstraints function to remove the dependency and keep it a generic method.

Type of change

[ ] Internal refactoring
[ ] Bug fix (bugfix - non-breaking)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

No changes are required from the client side.

changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: 02d1cf2de0a27f03c3352e18f8286ad688d78e4b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ------------------ | ----- | | @signalwire/webrtc | Patch | | @signalwire/js | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR