search

sigstore / sigstore-python

A Sigstore client written in Python
https://pypi.org/p/sigstore
Other
221 stars 46 forks source link

enable codecov (or similar)? #1153

Open gliptak opened 2 days ago

gliptak commented 2 days ago

Description

would you be interested in a PR uploading coverage results to http://codecov.io (or similar hosted location)?

https://github.com/codecov/example-python/blob/main/.github/workflows/ci.yml

might require generating and setting up a secret

https://about.codecov.io/tool/github/

empty project exists

https://app.codecov.io/gh/sigstore/sigstore-python

woodruffw commented 2 days ago

would you be interested in a PR uploading coverage results to http://codecov.io (or similar hosted location)?

I've had a lot of problems with CodeCov's reliability/uptime on other projects, so I'd prefer not to use a third-party service for this.

Long term, the goal is to get to 100% test coverage here -- when that happens, we can enable --fail-under 100 and gate PRs on that, with no third-party coverage service required.

Medium term, I think we could detect coverage regressions by persisting the current coverage level somewhere (GH actions artifacts?) and comparing against it. I remember seeing some prior art for that somewhere, but I'd need to find it again.

TL;DR: Thanks for the offer, but CodeCov in particular is not desired at the moment. We'd be interested in coverage regression tracking more generally, but that requires a bit of design thought.