search

sikuli / sikuli-api

41 stars 33 forks source link

Feature ideas #7

Open doubleshow opened 11 years ago

doubleshow commented 11 years ago

Original author: charles....@hungrymachine.com (November 22, 2012 22:02:48)

Hello,

I've been working on sikuli-clj (the Clojure wrapper) lately, and I've come across a couple things that would be handy to have in sikuli-api:

1) Add Mouse click "duration" param

I can implement these and send a pull request, if you agree that these belong in sikuli-api.

(BTW, is this the best place for discussing features/development?)

Oh, and thank you for such an awesome lib!

-Charles

Original issue: http://code.google.com/p/sikuli-api/issues/detail?id=7

doubleshow commented 11 years ago

From goeltsch...@gmail.com on November 25, 2012 14:32:46 Yeah, the lib is awesome!

That's my suggestion: since your library can select both WebElement and ImageElement, would be possible to have some convertor, trying to 1. capture WebElement fitting the image of ImageElement and thus getting it's properties like text if it has some text inside, or getting it's XPath. 2. capture ImageElement for renderd WebElement, specified by the xpath/cc selector/id and get some properties of ImageElement: OCR-processed text, size.

doubleshow commented 11 years ago

From doubles...@gmail.com on November 25, 2012 20:44:00 @Charles

Thanks for your positive feedback! Please go ahead and implement the new mouse operations as you suggested. The new Java API is structured with the intention to make community contribution a lot easier than before. We really appreciate your willingness to contribute. Feel free to send me a pull request when you are ready.

doubleshow commented 11 years ago

From doubles...@gmail.com on November 25, 2012 20:47:50 @goeltschaektschaek

Good idea about conversion. Thanks! Can you please give us a few concrete examples how you would use the conversion feature yourself, in Java pseudo code?

doubleshow commented 11 years ago

From miglecz on December 09, 2012 21:05:34 Please add returning value of this to Target interface set methods like:

I don't want to write: Target t = new ImageTarget(image); t.setMinScore(minScore); region.find(t);

instead i would like to write: region.find(new ImageTarget(image).setMinScore(minScore).set....);

Do 'return this' in all set methods where possible! Other classes also please in all the API!

Thanks

doubleshow commented 11 years ago

From charles....@hungrymachine.com on December 10, 2012 16:20:29 Alright, I've been sorta swamped with work, but I'll see if I can get in a PR for my feature request by end of day.

Re comment 4: I'll try to get a PR in for that too.