search

silencesys / silentbox

A lightbox inspired Vue.js component.
https://silentbox.rocek.dev
MIT License
296 stars 51 forks source link

Improperly Packaged for NPM #10

Closed DanielStout5 closed 5 years ago

DanielStout5 commented 5 years ago

This library looks great, but the fact the NPM package includes SASS and .vue files is not standard practice.

It means the library can't be used directly in the browser, and it means the user is required to ensure vue-loader includes node_modules (to translate the .vue files) and that their own project uses node-sass and sass-loader.

Here's the recommended best practice:

https://vuejs.org/v2/cookbook/packaging-sfc-for-npm.html#Can%E2%80%99t-I-Just-Share-vue-Files-Directly

silencesys commented 5 years ago

Thank you for the notice and an advice, the package should be repackaged and no longer requiring other modules.