silentsokolov / django-admin-rangefilter

A Django app that lets you filter data by date range and numeric range in the admin UI
MIT License
713 stars 106 forks source link

fix: properly display date and time placeholders for DateTimeRangeFilter #112

Open jsheffie opened 8 months ago

jsheffie commented 8 months ago

closes: #113

Changes:

Status: Alright, this is working for Django 4.2 and above. I am currently trying to figure out how to make this work on older versions of django.

Visualize

📸 Before: displays 'date' in the time fields ![Screenshot 2024-01-05 at 9 58 43 AM](https://github.com/silentsokolov/django-admin-rangefilter/assets/890028/c7fb8a0b-8638-468f-8775-7eaee06ceee6)
📸 After: displays 'time' in the time fields ![Screenshot 2024-01-05 at 9 55 58 AM](https://github.com/silentsokolov/django-admin-rangefilter/assets/890028/955a5cc4-07bf-42dd-ac7a-852a56d6617a)
codecov-commenter commented 8 months ago

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (b4f6c29) to head (01ffef8). Report is 15 commits behind head on master.

Files Patch % Lines
rangefilter/filters.py 57.14% 6 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #112 +/- ## ========================================== - Coverage 87.45% 86.70% -0.75% ========================================== Files 9 9 Lines 606 617 +11 ========================================== + Hits 530 535 +5 - Misses 76 82 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

silentsokolov commented 8 months ago

Look nice! Thanks you! I think it will take more time for testing to ensure there are no critical errors on older versions. After fix current tests