search

silentsokolov / django-admin-rangefilter

A Django app that lets you filter data by date range and numeric range in the admin UI
MIT License
713 stars 106 forks source link

Use proper Template comment tag #39

Closed nitinnain closed 4 years ago

nitinnain commented 4 years ago

Currently, if you right click on browser and "View Source", then the commented code shows up in the final HTML page. Using {% comment %} tag in django templates avoids placing the commented code in final HTML.

codecov-io commented 4 years ago

Codecov Report

Merging #39 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #39   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files           7        7           
  Lines         319      319           
=======================================
  Hits          308      308           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae5bdda...4c40cc8. Read the comment docs.

nitinnain commented 4 years ago

If you look at HTML source of a page which has this filter (using the "View Source" tool from a browser), you'll notice that the code comments from this extension are in the html page. That shouldn't be the case! Please consider merging this Pull Req. I've marked the code comments in red box here. rangefilter-comments-in-html

silentsokolov commented 4 years ago

Ok)) Thx!