search

silentsokolov / django-admin-rangefilter

A Django app that lets you filter data by date range and numeric range in the admin UI
MIT License
713 stars 106 forks source link

Drop support to deprecated Python and Django #70

Closed jairhenrique closed 2 years ago

jairhenrique commented 2 years ago

References.

https://endoflife.date/django https://endoflife.date/python

silentsokolov commented 2 years ago

Really big thanks for your PR!

But django-admin-rangefilter isn't celery or some large project where support 2.7 is hard work. So we're going to support it to the last ...

Thanks!

jairhenrique commented 2 years ago

How about starting a 1.0.0 branch with these changes and maybe keeping things deprecated in 0.8.X?

I believe this has nothing to do with the size of the project, but with the evolution of the language itself.

Maintaining support for things that there is no longer any core support from my point of view is unnecessary work and a delay to the evolution of the entire ecosystem.

In the meantime, I'll open another PR adding python 3.10 support.

codecov-commenter commented 2 years ago

Codecov Report

Merging #70 (342bf18) into master (9e2774c) will decrease coverage by 0.28%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
- Coverage   92.85%   92.56%   -0.29%     
==========================================
  Files           6        4       -2     
  Lines         168      148      -20     
==========================================
- Hits          156      137      -19     
+ Misses         12       11       -1
Impacted Files Coverage Δ
rangefilter/__init__.py 100.00% <ø> (ø)
rangefilter/filter.py 0.00% <ø> (ø)
rangefilter/apps.py 100.00% <100.00%> (ø)
rangefilter/filters.py 94.02% <100.00%> (-0.14%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e2774c...342bf18. Read the comment docs.