search

sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Added .NET Standard target to LibChorus and .NET6 to ChorusMerge. #279

Closed josephmyers closed 2 years ago

josephmyers commented 2 years ago

Also referencing the appropriate libpalaso .NET Standard DLL's, which drop support for USB operations (RepositoryAddress.cs). For the .NET Standard version, those operations now return null. These methods were already returning null in other situations, but if this is undesirable, we can throw a NotSupportedException, etc.

Also upgraded Autofac version to support the new framework and resolving that reference implicitly in Chorus.csproj.

Also added GH Actions build (and potentially removing TC and AppVeyor builds)

This change is Reviewable

josephmyers commented 2 years ago

The new GH workflow, though flaky, successfully builds, tests, and deploys. Deploying only happens for the .NET Standard projects currently, but this can be expanded. The overall goal here is to replace the TC builds.

jasonleenaylor commented 2 years ago

src/ChorusHubApp/ChorusHubApp.csproj line 14 at r1 (raw file):

    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
    <PackageReference Include="SIL.ReleaseTasks" Version="2.5.0" PrivateAssets="All" />
    <PackageReference Include="SIL.Windows.Forms" Version="9.0.0-*" />

10

Code quote:

9
josephmyers commented 2 years ago

.github/workflows/dotnet.yml line 29 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…
add --no-build?

sure, sounds good

josephmyers commented 2 years ago

.github/workflows/dotnet.yml line 35 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…
I'm not sure why there are two deploys here, and why one is specific to version 5 packages? Seems like that will require extra maintenance.

good catch. at time of writing i only wanted to push specific builds. we can change this to be more generic, i think "output*\.nupkg" would do it and only require one line

josephmyers commented 2 years ago

src/ChorusHubApp/ChorusHubApp.csproj line 14 at r1 (raw file):

Previously, jasonleenaylor (Jason Naylor) wrote…
10

yeah, rebase should fix!

josephmyers commented 2 years ago

Can we get rid of the warnings as well? (Maybe in a follow-up PR)

To do so, we can either change L10NSharp (not planned) or suppress NU1701. Which do you recommend? There is one other warning, one regarding an unrecommended/obsolete call. I'll look into this now