sillsdev / chorus

End-user collaboration library via 3-way xml merging and hg dvcs under the hood
6 stars 26 forks source link

Try to fix flaky test #330

Closed rmunn closed 8 months ago

rmunn commented 8 months ago

The ExternalFileModification_NotifiesIndices_ButSaveDoesNot test has failed repeatedly on the GHA runner. I suspect the test, that waits 10 seconds to get notified of a filesystem change, may need more time to run. If that isn't enough to fix it, we should remove the test entirely: there's already a comment about how flaky it is, but now it's becoming "reliably flaky", so to speak.


This change is Reviewable

github-actions[bot] commented 8 months ago

Test Results

       2 files  ±0     202 suites  ±0   1h 23m 1s :stopwatch: +20s    876 tests ±0     854 :heavy_check_mark: +1  22 :zzz: ±0  0 :x:  - 1  1 998 runs  ±0  1 932 :heavy_check_mark: +1  66 :zzz: ±0  0 :x:  - 1 

Results for commit de043543. ± Comparison against base commit 3de37715.