search

sillyfrog / Automate-Pulse-v2

Rollease Acmeda Automate Pulse Hub v2 integration for Home Assistant
Apache License 2.0
37 stars 8 forks source link

Integration is using deprecated `DEVICE_CLASS_*` constants #16

Closed frenck closed 1 year ago

frenck commented 1 year ago

This custom integration uses deprecated DEVICE_CLASS_* constants in its codebase.

The DEVICE_CLASS_* constants have been deprecated and replaced in Home Assistant Core 2021.12 (over a year ago). I would highly suggest updating/migrating this integration to the new enums.

For example, for the device classes supported by the sensor platform, there is now a SensorDeviceClass enum. So if a sensor previously used the DEVICE_CLASS_ENERGY constant, it should now use SensorDeviceClass.ENERGY. Other platforms (like binary_sensor, and number) provide similar enumerations for their supported device classes.

The migration thus only consists of replacing constants with an enumeration member and is, therefore, very low impact and should be fairly straightforward.

If I can help resolve any questions regarding this change or migration, feel free to ask or respond to this issue. I'm happy to help!

Kindest regards,

../Frenck

sillyfrog commented 1 year ago

Thanks.

I did the SensorDeviceClass some time ago, but now realized I missed the CoverDeviceClass, which is now fixed and I'll push a new release shortly.

Cheers.

sillyfrog commented 1 year ago

Fixed in v0.9.8

frenck commented 1 year ago

Thanks for the super fast response on this one @sillyfrog 👍

Happy New Year 🥂

../Frenck