Should not cache 3xx responses

sillygod / cdp-cache

a caddy 2 proxy cache plugin

MIT License

120 stars 18 forks source link

Should not cache 3xx responses #33

Closed danlsgiga closed 3 years ago

danlsgiga commented 4 years ago

As I'm evaluating this module, I noticed that it is not handling origin responses like 302 (Redirect). cdp-cache is responding with a 200 to the browser, therefore the redirect never happens!

A way to reproduce is just to proxy to an origin that does a 302 or 301.

Additionaly, it would be nice to control what responses we want to cache, usually only 200's

sillygod commented 4 years ago

Hi @danlsgiga,

Thanks for finding this issue and sorry for responding late. Recently, I am busy with other projects so I need some time to check this your PR.

sillygod commented 3 years ago

I'll close this issue because this bug has been fixed by another pull request #36 .