search

silverbulletmd / silverbullet

The knowledge tinkerer's notebook
https://silverbullet.md
MIT License
2.61k stars 189 forks source link

Do not use standardKeymap in vim mode #1145

Closed lutzky closed 2 weeks ago

lutzky commented 2 weeks ago

The standard keymap conflicts with the vim mode, e.g. not allowing arrow keys to move through the vim commandline for / and : commands. The keys described in https://codemirror.net/docs/ref/#commands.standardKeymap seem to work just fine without it in vim mode.

Fixes https://github.com/silverbulletmd/silverbullet/issues/976

zefhemel commented 2 weeks ago

Alright, let's try, people will scream if this breaks stuff :)

lutzky commented 2 weeks ago

Uhh... screamer here. I don't know how I missed this, but this breaks the Return key for ordinary paragraphs (it does nothing in Insert mode now). Super weird. Workaround is hitting o in Command mode instead; seeing as the previous version was destructive, this seems less bad, but still worth fixing. I'll take a look.

lutzky commented 2 weeks ago

I'll move discussion back to #976.