silverbulletmd / silverbullet

The knowledge tinkerer's notebook
https://silverbullet.md
MIT License
2.61k stars 189 forks source link

Service Worker can potentially break routing #1157

Open Pluckerpluck opened 1 week ago

Pluckerpluck commented 1 week ago

So I can't work out if there's some config I don't know about this, but I'm using cloudflared tunnels, and these work by adding an endpoint to your domains /cdn-cgi.

You can do things like navigate to /cdn-cgi/access/logout if you'd like, and that will be captured, and direct itself to log you out of your cloudflare tunnel. It's also used for authorizing new cookies while your existing one is still valid.

My problem is that I can't actually hit anything like domain/cdn-cgi/access/logout because (I think) the service worker captures the URL, and just creates a notes page for it! So now I can't log out using this system.

Is there a way to exclude paths that the service worker will just bypass? From what I can tell you just bypass when you get unauthorized errors, but in this case you just get 404s because you are authorized.


In short, I'd like to navigate to /cdn-cgi/access/logout to log out, but can't because the service worker tries to make a new note instead.