Core version compatibility filter doesn't work with recipe constraints (rather than framework)

[sunnysideup]

Almost half of the SS4 modules are not listed on addons.

Here is my evidence:

Search without 4 filter https://addons.silverstripe.org/add-ons?search=search+simple+smart&type=&sort=

Search with 4 filter

https://addons.silverstripe.org/add-ons?search=search+simple+smart&type=&compatibility%5B%5D=4.5&compatibility%5B%5D=4.4&compatibility%5B%5D=4.3&compatibility%5B%5D=4.2&compatibility%5B%5D=4.1&compatibility%5B%5D=4.0&sort=

In http://ssmods.com/#~(cfi~(Supports~(~(vtm~'4.*2a~ivl~'4.*2a)))~csr~(sdi~'desc~sct~'Created_U)) there are 1091 SS4 modules ...

[sunnysideup]

If confirmed, I can let you know how to fix it.

[robbieaverill]

I believe that the problem is that you're requiring a recipe - we advise against this, you should list the packages you depend on specifically rather than recipes of packages.

The addons site is only configured to look for dependencies on silverstripe/framework and silverstripe/cms when it determines the compatibility, at the moment. We should probably add things like silverstripe/admin, which is also a common dependency, but that would require some version remapping (to replace ^1.3 with ^4.3 for the sake of the search filters). See AddonUpdater::updateCompatibility() for reference.

---

The actions I can see here for this website are:

• Add recipe CMS and core to the list of package names to look for (even though we discourage people from depending on them in composer.json)
• Add silverstripe/admin to the list, and provide some version mapping logic to juggle 1.x releases to 4.x for compatibility checks

I'm not sure whether it's worth adding any other modules.

[robbieaverill]

Do you handle silverstripe/admin: ^1.0 dependencies as SilverStripe 4.x compatibility in your project?

[sunnysideup]

it will be ...