search

silverstripe / recipe-cms

Silverstripe recipe for fully featured page and asset content editing
BSD 3-Clause "New" or "Revised" License
20 stars 14 forks source link

Page and PageController show up in IDEs as valid classes #9

Open dhensby opened 6 years ago

dhensby commented 6 years ago

When using an IDE's "find class" feature, Page and PageController will often match two different files (the one in the project and the one in recipe-cms).

Please can we rename the files to have an extension like .tmpl or whatnot so that IDEs don't recognise them as PHP classes.

When we copy the files into projects we can copy and rename them instead to just copying them.

Related PRs

chillu commented 6 years ago

+1 - wanna send a PR?

dhensby commented 6 years ago

OK - so we need a PR to silverstripe/recipe-plugin to strip the .tmpl extension off files first.

tractorcow commented 6 years ago

Yep thanks for your work on this @dhensby I like the idea and think it's working well. Only one last thing on https://github.com/silverstripe/recipe-plugin/pull/5 to ensure the base project is renamed and we're golden.