Note that there may be some methods still on LeftAndMain that will be migrated into this class, such as save() which isn't used by CMSMain or ModelAdmin - but moving those will be handled by https://github.com/silverstripe/silverstripe-admin/issues/1763 once the bulk of the other refactoring has been completed. This is to reduce the chance of regressions in areas that still need to be refactored.
TODO
CMS 5 PR to deprecate SiteConfigLeftAndMain::save_siteconfig() and LeftAndMain.tree_config
I've responded to the bits that are relevant for the CMS 5 PRs. I'll make the requested changes that are agreed upon after the CMS 5 PRs have been merged and I can rebase on top of them.
Note that there may be some methods still on
LeftAndMain
that will be migrated into this class, such assave()
which isn't used byCMSMain
orModelAdmin
- but moving those will be handled by https://github.com/silverstripe/silverstripe-admin/issues/1763 once the bulk of the other refactoring has been completed. This is to reduce the chance of regressions in areas that still need to be refactored.TODO
SiteConfigLeftAndMain::save_siteconfig()
andLeftAndMain.tree_config
Issue