Closed kevingroeger closed 1 year ago
Thanks for the PR @kevingroeger. If the composer requirements are the only change needed, we can keep both 4 and 5 as well as 1 and 2 for the vendor-plugin to keep supporting both 4 and 5 versions of the CMS, right?
Thanks for the quick reply @michalkleiner
I applied your suggested changes
Seems like not both of them?
Yes, sorry. Just realised that when I tested it on SilverStripe4 again to be safe.
I applied the other one as well now.
Everything worked fine in both versions. Tested on 4.13 and 5.0
Thanks for that. No deprecations, no warnings in dev mode etc?
Surprisingly not. I would've expected some, but I haven't gotten any errors or warnings (in dev mode). Even searched my logs and didn't find any issues whatsoever.
-> Tested on a large-scale project