search

silverstripe / silverstripe-s3

Silverstripe module to store assets in S3 rather than on the local filesystem (SS4/SS5 only)
BSD 3-Clause "New" or "Revised" License
20 stars 25 forks source link

Update composer for CMS 5 compatibility #59

Closed kevingroeger closed 1 year ago

kevingroeger commented 1 year ago

-> Tested on a large-scale project

michalkleiner commented 1 year ago

Thanks for the PR @kevingroeger. If the composer requirements are the only change needed, we can keep both 4 and 5 as well as 1 and 2 for the vendor-plugin to keep supporting both 4 and 5 versions of the CMS, right?

kevingroeger commented 1 year ago

Thanks for the quick reply @michalkleiner

I applied your suggested changes

michalkleiner commented 1 year ago

Seems like not both of them?

kevingroeger commented 1 year ago

Yes, sorry. Just realised that when I tested it on SilverStripe4 again to be safe.

I applied the other one as well now.

Everything worked fine in both versions. Tested on 4.13 and 5.0

michalkleiner commented 1 year ago

Thanks for that. No deprecations, no warnings in dev mode etc?

kevingroeger commented 1 year ago

Surprisingly not. I would've expected some, but I haven't gotten any errors or warnings (in dev mode). Even searched my logs and didn't find any issues whatsoever.