Taxonomy directory - problems to be solved

[robbieaverill]

I've just had a look at the TaxonomyDirectorController in the context of CWP 2.0. Here are some issues I've noticed:

• The template is in the wrong namespace (fix at #54)
• There is coupling between taxonomy and CWP that should not exist (see comment thread in #40)
• The query only works if Page has a database table, which requires at least one form field on Page
• The starter theme doesn't have a template for it, so spans full width (see https://github.com/silverstripe/cwp-starter-theme/issues/41)

I actually think that this class shouldn't be in this module - BasePage is specific to CWP, and this logic should live in the cwp/cwp module or something similar.

I think we should deprecate the class and move it back to a documentation only example. If it should live in CWP then we can add it to CWP later on. Thoughts?

[NightJar]

The PR is https://github.com/silverstripe/silverstripe-taxonomy/pull/45#discussion_r160744058 with the comment thread in question (which is aimed to supercede #40 by the PR description).

I feel like dot notation can solve the issue of the phantom BasePage, and remove the innerJoin custom query logic. This is particularly helpful in SS4 with different/adaptive/settable table names. The dot notation reference can be built by a relation lookup, which can be defined via injector service definitions.

Caveat that I've not thought too deeply about this yet. Just initial thoughts.