search

silverstripe / silverstripe-versionfeed

Provides an RSS feed for global site changes
BSD 3-Clause "New" or "Revised" License
4 stars 13 forks source link

Investigate if replacing RateLimitFilter could be replaced by Core features #50

Open NightJar opened 6 years ago

NightJar commented 6 years ago

SilverStripe Framework provides us SilverStripe\Core\Cache\RateLimiter which may (or may not) provide the same service for less code. It'd mean less maintenance too. Is it possible to make the replacement?

robbieaverill commented 6 years ago

I think this is a sensible idea

dhensby commented 6 years ago

It should be straightforward to apply the RateLimitMiddleware to the VersionFeedController which would do away with the need for your own rate limiter.