search

silx-kit / vscode-h5web

VSCode extension to explore and visualize HDF5 files
https://marketplace.visualstudio.com/items?itemName=h5web.vscode-h5web
MIT License
33 stars 5 forks source link

`Open Changes` view raises a `Expected valid HDF5 file` error for added file #22

Closed loichuder closed 1 year ago

loichuder commented 1 year ago

Describe the bug

When having a HDF5 added in a workspace with git, it is possible to use the Open Changes view to see the differences between files:

image

When opening the file in this view, the left panel shows a Expected valid HDF5 file while the right panel works fine.

To Reproduce

  1. Open a workspace with source control (git)
  2. Create an HDF5 file
  3. Go in the Source Control tab
  4. Open the file with Open Changes
  5. See error

Expected behaviour

Perhaps we could display "No HDF5 file" instead ? Might be hard to detect though.

Screenshots

image

Context