search

simion / sublime-slack-integration

A ST3 plugin which sends messages, code selections and files to slack.com channels/groups/users.
http://simionbaws.ro/sublime-text-3-slack-integration-plugin/
GNU General Public License v2.0
70 stars 7 forks source link

Does not work behind a proxy #6

Open saily opened 9 years ago

saily commented 9 years ago

Because urllib does not use system proxy by default, this will not work in a proxied environment. If you start from command line and use the curl fallback, it works fine.

  1. think about using requests instead of urllib which automatically reuses proxy environment
  2. allow proxy configuration in user settings.

what do you think?

simion commented 9 years ago

Will rewrite api to use requests :)

saily commented 9 years ago

I just forked the project and try to contribute some code.

simion commented 9 years ago

Awesome, I'll leave it in you then. The change should be simple. I wasn't aware of requests when i wrote the plugin, that's why it is build with urllib :)

saily commented 9 years ago

the thing i'm not sure about is that requests is not a python standard lib. this will blow up the plugin and i'm not quite sure how to ship 3rd party libraries within the plugin.

simion commented 9 years ago

http://stackoverflow.com/a/15180938 You could give it a try.

simion commented 9 years ago

Any progress with including requests bundle into the plugin? :)

saily commented 9 years ago

i did not event have time to follow your link :-) if you can do it earlier, i'd really appreciate