search

simonhamp / statamic-heroicons

Bring Heroicons to Antlers in Statamic
https://statamic.com/addons/simonhamp/heroicons
MIT License
3 stars 3 forks source link

aria-hidden="true" #4

Open stephenmeehanuk opened 2 years ago

stephenmeehanuk commented 2 years ago

Hi

This is a great Statamic Add-on, thanks for making it.

Would it be possible to add the option to conditionally add aria-hidden="true" to the svg tag?

This is what I'm trying to do https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-hidden#example

simonhamp commented 1 year ago

@stephenmeehanuk I've created a PR for this. Can you give that a go when you've got time and let me know if it works for you