simonsteele / pn

Programmer's Notepad
374 stars 116 forks source link

Patch for Project Groups and Caret Slop #31

Closed simonsteele closed 9 years ago

simonsteele commented 9 years ago

Original issue 2 created by simonsteele on 2008-03-10T13:43:47.000Z:

Fixes contributed by Jarek Bartkowiak:

  1. Added options for setting scintilla's y caret policy. As a default PN2 uses 3 lines as the jump when scrolling up and down, which is not my favourite. I added two options to let the user to configure it (see Options_dialog.jpg - this are the options I prefer).
  2. If you rename project and then close PN2 no "Save modified items" prompt is displayed. Renaming project does not set its 'dirty flag'. I fixed Folder::SetName(LPCTSTR name_) method in project.cpp to solve this problem.
  3. Saving and restoring workspace changes order of the open files and does not preserve selected (focused) file (see Workspace.jpg and Workspace_after_restore.jpg).

I only managed to do minor modifications that preserve selected file (CMainFrame::WorkspaceChildCloseNotify() method in mainfrm.cpp). To solve this problem one should modify 'pnws' file format (add 'selected file' attribute) and change method that gets open documents list. The problem is that this method call Win32 EnumChildWindows function that enumerates windows in its Z order (not the true order of the document windows).

  1. Minors changes in methods that save workspaces. See CMainFrame::OnFileSaveWorkspaceState() and CMainFrame::SaveWorkspaceAs() methods.
simonsteele commented 9 years ago

Comment #1 originally posted by simonsteele on 2008-03-16T22:13:58.000Z:

Migrated From: http://sourceforge.net/tracker/index.php? func=detail&aid=1844725&group_id=45545&atid=443221

simonsteele commented 9 years ago

Comment #2 originally posted by simonsteele on 2008-03-24T20:34:54.000Z:

<empty>

simonsteele commented 9 years ago

Comment #3 originally posted by simonsteele on 2008-06-09T21:46:21.000Z:

Only thing remaining is some UI for caret stuff

simonsteele commented 9 years ago

Comment #4 originally posted by simonsteele on 2008-07-30T22:14:19.000Z:

Now done, thanks!