search

simonvanderveldt / norns-image

5 stars 2 forks source link

Remove all hardcoded (serial) console service files #40

Closed simonvanderveldt closed 4 years ago

simonvanderveldt commented 4 years ago

These are incorrectly created by buildroot and cause either a warning or real issues where the serial console won't work depending on what BR2_TARGET_GENERIC_GETTY_PORT is set to. To ensure this doesn't happen we simply delete all the files (which buildroot has created) in /etc/systemd/system/getty.target.wants

This behavior has been incorrect in buildroot for a while but with the introduction of https://github.com/buildroot/buildroot/commit/940e7deab09e34585a5b70dd6ce1c9afd22fd8f3 it broke our serial console.

The default should be to not create any of these when systemd is used and let the user add additional ones if he/she wants to.

simonvanderveldt commented 4 years ago

Checked the image built by Circle and it works correctly now :)