simple-last-fm-scrobbler / sls

Simple Scrobbler, for Android -- last.fm, libre.fm & ListenBrainz
https://simple-last-fm-scrobbler.github.io
Apache License 2.0
550 stars 99 forks source link

Upgrade Loses Login Credentials #513

Open MunifTanjim opened 5 years ago

MunifTanjim commented 5 years ago

Updating from Google Play store removes the login info and scrobble cache.

Android Version: 9

borealissw-admin commented 5 years ago

Exactly the same behaviour here for auto-update.

Is the data lost or is it recoverable?

App Version: v1.6.3 Android Version: 8.1.0 Phone Model: Moto G5 Plus

borealissw-admin commented 5 years ago

Almost exactly the same thing happened with 1.6.5 - Scrobble cache lost, credentials kept, correction rules lost, enabled apps kept.

I'm disabling auto update and beta program until this one's sorted.

a-r-db commented 5 years ago

app-debug__custom.apk.zip

If either of you are brave enough. This apk has the patches that will allow better database migration without destroying scrobbles and it should store scrobbles quietly even when you are logged out. The cache will store them but not display the amount until you log in and scrobble them all.

a-r-db commented 5 years ago

It also stores music you've already sent so you can use that data to modify track fixes and things like that.

MunifTanjim commented 5 years ago

I was brave enough to install 😂 But it doesn't even start now, just crashes 😅

a-r-db commented 5 years ago

Oh no.

MunifTanjim commented 5 years ago

The latest Play Store release still has this problem. Login credential got removed.

TheQwertiest commented 5 years ago

Same here - both 1.6.* and 1.7.0 removed all user settings and data (and I missed month worth of scrobbles because of it =( )

insanity35 commented 5 years ago

1.6.x and up to 1.7 don't migrate my settings either.

a-r-db commented 5 years ago

hmm.. Could be something I have done with making the passwords encrypted in the app preferences store. Security vs Functionality type problem.

a-r-db commented 5 years ago

I will make this a priority.

a-r-db commented 5 years ago

@insanity35 login credentials or everything? I have created a database migration in the code setup.

a-r-db commented 5 years ago

538 Should resolve database issues.

However with login credentials I have yet to find out the cause.

a-r-db commented 5 years ago

https://issuetracker.google.com/issues/36907037