simplesamlphp / saml2

SimpleSAMLphp low-level SAML2 PHP library

https://www.simplesamlphp.org

GNU Lesser General Public License v2.1

286 stars 135 forks source link

Rewrite assertion #230

Closed tvdijen closed 3 years ago

tvdijen commented 4 years ago

Closes #192

codecov[bot] commented 4 years ago

Codecov Report

Merging #230 (c7abcda) into master (70bdfbd) will increase coverage by 9.18%. The diff coverage is 93.40%.

@@             Coverage Diff              @@
##             master     #230      +/-   ##
============================================
+ Coverage     76.53%   85.71%   +9.18%     
+ Complexity     2407     1971     -436     
============================================
  Files           166      159       -7     
  Lines          6017     4795    -1222     
============================================
- Hits           4605     4110     -495     
+ Misses         1412      685     -727

tvdijen commented 3 years ago

Thanks for your review Michiel! We put a lot of effort in getting near-perfect coverage for the XML-directory, taking the coverage of the entire library from 60 to around 85%.. That should pay of in the future.