search

simplesamlphp / saml2

SimpleSAMLphp low-level SAML2 PHP library
https://www.simplesamlphp.org
GNU Lesser General Public License v2.1
284 stars 135 forks source link

Throw a specific exception for unsupported binding. #289

Closed thijskh closed 2 years ago

thijskh commented 2 years ago

Either whether there's a type specified that we don't know or if the guessing failed (the exception message will discern the two cases). This allows SimpleSAMLphp to handle this more neatly.

tvdijen commented 2 years ago

Duplicate of #285 Would you mind taking a look at that one?

thijskh commented 2 years ago

It's not that obvious to me how inside getBinding/getCurrentBinding we would decide if it's the requester or responder's "fault"?

tvdijen commented 2 years ago

You're right, and it's probably irrelevant.. The exception should be caught somewhere where it is possible to determine if it's a requester/responder issue..

tvdijen commented 2 years ago

I suspect this is something you need for OC? I will backport this to a new 4.3 branch.. We may be able to use some of this in SSP 2.0