search

simular-ai / Agent-S

Agent S: an open agentic framework that uses computers like a human
https://www.simular.ai/agent-s
Apache License 2.0
641 stars 85 forks source link

OpenACI Interface Discrepancy with Linux/MacOS #17

Open Elements- opened 1 month ago

Elements- commented 1 month ago

I'm struggling to get OpenACI & AgentS in their current state to work without heavy modifications (tested across 4 environments now).

I'm getting an error from the OpenACI Ubuntu grounding agent about a missing obs param, see the signature here:

#ubuntu Grounding.py @ OpenACI
class GroundingAgent:
    def __init__(self, obs, top_app=None):
        self.input_tree = obs['accessibility_tree']
        self.screenshot = obs['screenshot']

I noticed, in the MacOS Grounding agent (which appears to be interchangeable, that param doesn't exist:

#macos Grounding.py @ OpenACI
class GroundingAgent:
    def __init__(self, top_app=None, top_app_only=True, ocr=True):
        self.active_apps = set()
        self.top_app = top_app

Is this discrepancy intentional? Trying to figure out how to get it running on Linux but dont want to go making a ton of changes if I just have this setup wrong.

eric-simu commented 2 days ago

Hi, we just refactored the codebase and fixed some bugs. can you try the new release?