simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
7 stars 3 forks source link

keyboard navigation: feature/focus states #589

Closed interim17 closed 1 month ago

interim17 commented 1 month ago

Time estimate or Size

medium/small

Problem

Closes #575 and #576, advances #347 Part of keyboard navigation and accessibility work.

Solution

Focus styling for action buttons has been reviewed with Lyndsay but is not reflected in master Figma yet. Styling for primary/secondary buttons, and dropdown elements is there. Style guide

Closing #576 because they already work, its clear how to tab through them now that the visual style is obivous.

Disabled buttons are taking focus/styling for now, this can be discussed more in future as we get into navigation behavior.

CustomDropdown

Wrapper for our Dropdowns, unifies the stylesheets, just a slight DRYing now, but will be very useful going forward.

Steps to Verify:

  1. Tab through header and try action buttons (AICS home link, Simularium home link, Download, Share)
  2. Open dropdowns and check on hover and focus styling (focus styling is difficult to maintain sometimes with mouse interactions. Easiest way to see it is the use the buttons that open the submenus.

Applying focus styling to ALL interactive elements is out of scope for this PR (e.g. submenu items in drop-downs)

Screenshots (optional):

Screenshot 2024-10-16 at 2 51 56 PM Screenshot 2024-10-16 at 2 51 50 PM Screenshot 2024-10-16 at 2 51 43 PM
github-actions[bot] commented 1 month ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements
66.27% (-0.46% πŸ”»)
676/1020
🟑 Branches
65.31% (-1.36% πŸ”»)
96/147
πŸ”΄ Functions
35% (-0.25% πŸ”»)
91/260
🟑 Lines
64.66% (-0.41% πŸ”»)
602/931

Test suite run success

121 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from c2ac2a01f5f59928739c9b4bf87e81589c466788