simularium / simularium-website

Front end website for the Simularium project, includes the Simularium viewer
https://simularium.allencell.org
Apache License 2.0
7 stars 3 forks source link

remove erroneous overflow bar #611

Closed interim17 closed 2 weeks ago

interim17 commented 3 weeks ago

Time estimate or Size

tiny

Problem

Empty viewer and trajectories with no plots were showing a scroll bar on the right side panel head.

Remove this overflow-y property. I think overflow styling on the side panels could use a touch up, but this is just buggy and needs a fix.

Screenshot 2024-11-06 at 3 24 45 PM
github-actions[bot] commented 3 weeks ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
🟑 Statements 66.76% 691/1035
🟑 Branches 66.67% 102/153
πŸ”΄ Functions 35.25% 92/261
🟑 Lines 65.11% 614/943

Test suite run success

129 tests passing in 7 suites.

Report generated by πŸ§ͺjest coverage report action from 9a208327a50afd58120acc5c86e518b246adffbb

meganrm commented 3 weeks ago

does this still scroll when there are more plots than fit in the height of the window?

interim17 commented 2 weeks ago

does this still scroll when there are more plots than fit in the height of the window?

yes, I think it's possible that design should be freshened up, but it still behaves as it should, as does the other panel