simulationcraft / simc

Simulationcraft engine/GUI
GNU General Public License v3.0
1.42k stars 704 forks source link

[shaman] Misc Lightning Rod / Conductive Energy fixes #9723

Closed wfarr closed 1 month ago

wfarr commented 1 month ago

This change seeks to correct some bugged behavior in sims with regards to Lightning Rod (the talent), Lightning Rod (the debuff), and Conductive Energy (the talent).

For Enhancement, Conductive Energy makes Elemental Blast, Lightning Bolt, Chain Lightning, and Tempest all apply Lightning Rod (the debuff) whilst not having Lightning Rod (the talent).

For Elemental, Conductive Energy makes Tempest damage accumulate into Lightning Rod (the debuff) and makes Tempest also apply the Lightning Rod (debuff) regardless of whether or not the Lightning Rod (talent) is taken, based on tooltips and in-game testing.

Additionally for Elemental, the spells Elemental Blast, Earthquake, and Earth Shock only should proc Lightning Rod (the debuff) IFF Lightning Rod (the talent) is selected.

simc was exhibiting the following behavior instead:

wfarr commented 1 month ago

Additional finding: