search

sinanozaydin / pide

A python library for petrophysical calculations.
https://pide.readthedocs.io/
GNU General Public License v3.0
5 stars 2 forks source link

JOSS Review: Example Notebook `7_Metasomatism` #4

Closed kujaku11 closed 2 weeks ago

kujaku11 commented 3 months ago

When running Jupyter notebook examples/7_Metasomatism.ipynb the following error occurred on import [using pip install --> v0.3 and notebooks from main branch]:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 6
      4 from scipy.interpolate import griddata
      5 import matplotlib.pyplot as plt
----> 6 from netCDF4 import Dataset
      8 import pide
      9 from pide.mt.mt_model_read import read_ModEM_rho

ModuleNotFoundError: No module named 'netCDF4'

If netCDF4 is needed suggest adding it to the setup.py or if its not be sure to note that in the notebook and provide instructions on how to install.

After a pip install netCDF4, notebook runs fine.

sinanozaydin commented 2 months ago

netcdf4 is added to the setup.py at the new post-joss branch.

kujaku11 commented 2 weeks ago

@sinanozaydin works with post-joss branch.