sinara-hw / Sayma_AMC

AMC FPGA carrier board with FMC, dual SFP and RTM
8 stars 6 forks source link

WR connections #5

Closed hartytp closed 5 years ago

hartytp commented 5 years ago

Notes on my review:

hartytp commented 5 years ago

@marmeladapk one thing I haven't done is check the current consumption from the P3V3_CDR rail and ensure that it is safely within the limits of the LDO (assuming both the SI5324 and the LVPECL DXCOs are used at the same time). Do you need me to do this, or will it be done by whoever reviews the other supplies?

Also, if the LDO is a LT3045 instead of an LT3042 then I believe that larger capacitors are recommended (also, need to check the reduction in capacitance due to the DC bias voltage).

marmeladapk commented 5 years ago

Helper DCXO doesn't go to 2,5V bank as indicated in the note, it goes to HP. Output divider should probably also be changed.

marmeladapk commented 5 years ago

Why does helper DCXO have different short to ground (_N line) than main DCXO?

marmeladapk commented 5 years ago
marmeladapk commented 5 years ago

Should IN_SEL (ADCLK948) have pull-up/down resistor to select default?

tprzywoz commented 5 years ago

As @marmeladapk said Helper DCXO go to 1.8 V bank, not 2.5 V. Also Helper has both: DC coupling and DC bias voltage on FPGA input.

gkasprow commented 5 years ago
* @gkasprow what is the additional cost of making J34 + J35 MMCX instead of UFL? Makes the connections a bit more robust

the same, done

* @gkasprow why does it say "NOT USED" by IO_L24{P,N}_T3U_N1{0,1}_66? These are used for the recovered clock.

fixed

* not important, but on the current Kasli schematics we don't connect to Si5324 INT_C1B. On Sayma you connect that to the AMC FPGA. AFAICT, we don't need this line, so we could drop it to save an FPGA pin.

It's already routed.

* currently, the Si5324 CLKOUT1 is not connected to anything. Should we connect that to an FPGA MGTREF pin? Now that we don't have the HMC7043 on the RTM, we don't have a programmable clock source to generate the transceiver clock (due to limitations of the transceiver PLL, we may need different clock frequencies for different JESD line rates). @sbourdeauducq should make a decision on this

we use HMC7043. Shall I connect it to CLK1 of bank 226?

* @gkasprow what is AMC_TELECOM_CLOCK?

It is a clock delivered by MCH. In our case, it is delivered by WR timing module that sits on the MCH.

* replace 100k resistor to ground by J3 with 0R

done

* thinking about this a bit more, I'm concerned that the decoupling between the decoupling between the various P3V3_CDR supplies. The helper DCXO runs at a different frequency to the master, so any power-supply rail coupling will add close-in spurs onto the master. Similarly, if the Si5324 is used to drive a MGTREF, it could be used to produce a different frequency to the WR PLL. I think the best approach would be to produce the circuit the way it is, test it carefully when the boards arrive and only add more filtering/LDOs if we find an issue. On the other hand, an extra LC filter is cheap and may avoid issues. What do you think @gkasprow

I added already L18 and L19 and 4.7uF || 1nF caps We don't need low-frequency filtering, do we?

* the divider for the main DCXO is not correct. With the connections you have, the ADCLK948 internal 50Ohm termination is enabled, so the 200Ohm source impedance will give quite a low signal. Either disable the ADCLK948 termination (but then be careful about the distance between the DCXO an ADCLK948) or use a smaller source impedance.

changed to 49R9

* for the helper DCXO please add a note indicating which logic standard and termination should be used. I assume you want this to be used with unterminated LVCMOS? If so, then be careful in the layout to avoid a long length of unterminated trace

True, we use 1.8V LVCMOS. That's why 150R + 200R divider was used. But it has a roughly 80Ohm output impedance. The diff pair with one line grounded would have similar impedance, so that should work.

gkasprow commented 5 years ago

I think we can close it. The free clock output of Si5324 has other phase relationship than currently used one. Moreover, we have 2 clocks connected between and bank 225 and 224 I also routed another copy of CDR clock to bank227 to enable clocking of all MGTs.

sbourdeauducq commented 5 years ago

The free clock output of Si5324 has other phase relationship than currently used one.

Yes, it is important that all clocks should be derived from the same Si5324 output. Except in very special circumstances, the two outputs have a random phase relationship with each other after each Si5324 reboot.