sinara-hw / Waver_FMC

Four channel DC-coupled, 10Vpp capable, 1.5GS/s AWG FMC
1 stars 0 forks source link

review #4

Closed gkasprow closed 2 years ago

gkasprow commented 2 years ago

@filipswit I looked once again on the project and found a several mostly cosmetic issues:

filipswit commented 2 years ago

I'd add pulldown resistor for OSC_EN_VADJ similar to R57, and R58. The default setting for IC1 should be an external clock because the internal one may be unknown before initiaisation.

I've changed pd to pu on CLK_SEL_0, so now default input is (IN1) MMCX

LT1963 will not be stable with C227. Replace it with a suitable tantalum one and make sure there are no bulk caps on this rail.

Output caps C233 and C234 changed as well

add P12V0/GND test points to the PSU board to enable soldering of supply cables during debugging.

I've added also P3V3 test point and pu for power enable.

the buck converter loop current is not optimal. Move the L200 up and output capacitors between IC100 and L200

Now should be better:

image