search

sindresorhus / np

A better `npm publish`
MIT License
7.56k stars 299 forks source link

NIT: Yarn warning np@7.6.2: The engine "git" appears to be invalid. #663

Open meandavejustice opened 2 years ago

meandavejustice commented 2 years ago

Description

This is a nit, not at all breaking functionality bug. Just thought I would note it.

The warning warning np@7.6.2: The engine "git" appears to be invalid. is displayed when installing np.

I think listing git version in the engines field of package.json is a clever and appropriate place for the listing. Would be nice if there was not a warning for it. Could be cool to see it tacked on to an upstream issue on npm.

Steps to reproduce

  1. yarn add --dev np

Expected behavior

No warning

Environment

np - ^7.6.2 Node.js - v16.13.0 npm - 8.1.0 Git - 2.25.1 OS - Ubuntu 20.04.5 LTS (WSL2)

fregante commented 1 year ago

Related: https://github.com/sindresorhus/np/pull/406

np decided to extend package.json and Yarn decided to validate it. 😅 I don’t think we'll reach an agreement on that