Improve transliteration for russian language - Githubissues

sindresorhus / transliterate

Convert Unicode characters to Latin characters using transliteration

MIT License

286 stars 20 forks source link

Improve transliteration for russian language #17

Closed yhdgms1 closed 3 years ago

yhdgms1 commented 3 years ago

This transliteration uses Yandex Maps transliteration schema which is easy to read and good in pronunciation. And in that pull request i used tabs and single-quotes

sindresorhus commented 3 years ago

@AlexxNB Could you review?

AlexxNB commented 3 years ago

Personaly I don't like a variant for ъе->y. Russian word like подъезд will be podyzd and can't be phonetically read as original . Current variant podezd is better choice. Or may be improved to ъе->ye and podyezd will have best match.

AlexxNB commented 3 years ago

Oh, it is look like @Artemis69 just have an error there

yhdgms1 commented 3 years ago

Oh, I think I was wrong. Sorry for the inconvenience

AlexxNB commented 3 years ago

No problem, just add the commit here to fix it. Other things are good replacements.

yhdgms1 commented 3 years ago

I hope I did everything right. I am newbie ＞﹏＜

AlexxNB commented 3 years ago

@Artemis69 I also think that you should move ЪЕ before Е declaration

yhdgms1 commented 3 years ago

@AlexxNB, yeah, you are right. Thanks!

AlexxNB commented 3 years ago

@sindresorhus now looks good for me

sindresorhus commented 3 years ago

Thanks to you both :)