search

sindresorhus / wallpaper

Manage the desktop wallpaper
MIT License
1.05k stars 91 forks source link

Add suppport for KDE/Plasma #28

Closed maxanier closed 7 years ago

maxanier commented 7 years ago

On my linux system with Plasma (running Arch Linux/Manjaro) this tool does not work since neither gsettings nor gconftool-2 nor dcop work even though they are present.

This PR adds a working method using qdbus.

Without #27 or similar this does not really help as the other ones (gsettings ...) are present and used first. As a workaround I just manually delete all other services from the lib/linux.js script for now.

sindresorhus commented 7 years ago

this does not really help as the other ones (gsettings ...) are present and used first.

Can't we just change the order to prefer this if available over gsettings?

maxanier commented 7 years ago

I think qdbus is available on (at least some) other systems (not running Plasma) as well, so it would be used instead of gsettings and thereby break the functionality.

sindresorhus commented 7 years ago

We could detect if Plasma is installed then.

sindresorhus commented 7 years ago

I did some formatting tweaks. Can you confirm it still works?

maxanier commented 7 years ago

Yes, we could check for plasmashell for example. However, this would of course require a modification of the program structure as it currently checks the cmd for availability. So we have to add an additional check for an optional command.

As this probably affects other desktops as well I suggest doing this separate from this PR.

Will check your changes when I am home

maxanier commented 7 years ago

Works