search

singer-io / singer-python

Writes the Singer format from Python
https://singer.io
Apache License 2.0
538 stars 128 forks source link

Update jsonschema version range. #126

Closed manavkohli closed 4 years ago

manavkohli commented 4 years ago

Description of change

This includes the same changes as in https://github.com/singer-io/singer-python/pull/123, however, I signed the contribution agreement. This dependency issue precludes the use of any singer taps/targets with Google Cloud Composer since the builds fail with jsonschema version incompatibilities. This change will also avoid confusion for those viewing the Stitch Medium post Superching ETL with Airflow and Singer. For those hosting Airflow themselves, @feluelle further describes the motivations for the change:

"Airflow 1.10.7 added the jsonschema dependency to support serializing/deserialising data in its meta database. Because singer-python pins the jsonschema version to 2.6.0, it can no longer be used in Airflows newer versions in the same Python venv.

This change would allow users to use singer-python in a newer Airflow Environment."

Manual QA steps

Risks

Rollback steps

manavkohli commented 4 years ago

I also created a separate placeholder PR for updating tap-shopify: https://github.com/singer-io/tap-shopify/pull/56

manavkohli commented 4 years ago

I also added another PR in target-stitch: https://github.com/singer-io/target-stitch/pull/88

manavkohli commented 4 years ago

I also added a PR in tap-facebook: https://github.com/singer-io/tap-facebook/pull/94

manavkohli commented 4 years ago

I also added a PR in tap-adwords: https://github.com/singer-io/tap-adwords/pull/67

manavkohli commented 4 years ago

Finally, added in the tap-shippo project: https://github.com/singer-io/tap-shippo/pull/9

feluelle commented 4 years ago

Thanks @manavkohli for continuing it :) 👍

manavkohli commented 4 years ago

Closing due to inactivity