Closed rubenharutyunov closed 7 months ago
Hi @rubenharutyunov, thanks for your contribution!
In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.
You did it @rubenharutyunov!
Thank you for signing the Singer Contribution License Agreement.
Verified that this is a non-breaking change. Approving this.
Description of change
Currently, tap's subscription schema doesn't include manual discounts. This PR updates the subscription schema to include missing discount attributes based on Chargebee API.
Manual QA steps
python setup.py install
), configured to use our Chargebee sitetap-chargebee --config config.json --discover > catalog.json
), verified that it contains new attributestap-chargebee --config config.json --catalog catalog.json
) and verified thatRECORD
documents now contain manual discounts (where applied)Risks
None I can think of
Rollback steps