singer-io / tap-chargebee

Singer.io tap for extracting data from the Chargebee API

https://www.singer.io/

GNU Affero General Public License v3.0

7 stars 32 forks source link

fix: Prevent truncating invoice lineItem taxRates #80

Open armordog opened 2 years ago

armordog commented 2 years ago

tax_rate can't be stored as an integer because many states allow fractional tax rates

This change makes it match credit_notes.json's tax_rate (which stores correctly as a float)

Description of change

Changed invoice schema to prevent tax_rate from being stored as an integer

Potential Risks

I have no idea what this will do with existing tables

cmerrick commented 2 years ago

Hi @armordog, thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes.

cmerrick commented 2 years ago

You did it @armordog!

Thank you for signing the Singer Contribution License Agreement.

armordog commented 2 years ago

Just a reminder that this is still broken and still reporting incorrect tax rates.

armordog commented 1 year ago

Aw man I missed this issue's birthday 🎂

RushiT0122 commented 1 year ago

Looking into this.

RushiT0122 commented 1 year ago

This issue is fixed in PR #102.