single-spa / single-spa-angular

Helpers for building single-spa applications which use Angular
Apache License 2.0
203 stars 78 forks source link

fix: remove `"browser": "src/main.ts"` from `angular.json` (Fixes Issue #507) #508

Closed iamajmalhassan closed 7 months ago

iamajmalhassan commented 7 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Angular v17 onwards "browser": "src/main.ts" is getting added to the build options of angular.json which causes the following error during build/serve:

Error: Schema validation failed with the following errors:
  Data path "" must NOT have additional properties(browser).

Issue Number: #507

What is the new behavior?

The PR removes the browser key from the build options if it exists. The angular v17 application should now build without error.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information