single-spa / single-spa-vue

a single-spa plugin for vue.js applications
MIT License
182 stars 42 forks source link

fix: only create single-spa-container element when not using replaceMode #109

Closed FelixGraf closed 1 year ago

FelixGraf commented 1 year ago

When using the replaceMode: true option, it is not needed to create the wrapper div.single-spa-container element. When using replaceMode: true alongside SSR, this creates a hydration mismatch, as Vue does not expect the div.single-spa-container element to exist.

fooku18 commented 1 year ago

I support this change!

joeldenning commented 1 year ago

Released in https://github.com/single-spa/single-spa-vue/releases/tag/v3.0.0