search

single-spa / single-spa-vue

a single-spa plugin for vue.js applications
MIT License
182 stars 42 forks source link

Fix types for props #91

Closed Lalaluka closed 2 months ago

Lalaluka commented 2 years ago

I finally came around working on #86 was a bit more than you proposed @joeldenning but now it should work.

Tests are passing and I also installed the renewed package in a Vue2 and Vue3 Application and it still works.

(I also updated the single-spa version)

kosmos commented 2 years ago

Can you please review this PR. We need this patch.

rkovinko commented 2 years ago

This fix really important for us too, it allow us to use typescript in applications. review please.

Dmitriyes7 commented 2 years ago

Same for us. Could you please review it and merge as soon as possible? Thanks!

SmartXXI commented 2 years ago

Guys, please, review this PR.

svyatoslav-e commented 2 years ago

Hi, @Lalaluka I've tested your solution locally and it looks like issue still present when I try to pass any other custom props. render?: (this: AppProps) => any; in this line we define "this" as AppProps and error is next: 'customProp' does not exist on type 'AppProps'

joeldenning commented 1 year ago

Is this still a problem? The code looks fine, but @svyatoslav-e's comment makes me unsure that it fully fixes the problem

petarcekic-SportRadar commented 3 months ago

Can someone fix this please

joeldenning commented 2 months ago

This pull request is old and has conflicts and open questions. A new PR might be best to solve the problem.