Code inspection AtomSpaceNode

andre-senna commented 2 months ago

[ ] Improve documentation of join_network() to explain that the definition of joining a network from the perspective of a node is to recognize an elected leader
[ ] Check node ID against expected syntax to the concrete network and to prevent id clash.
[ ] Enforce "localhost" as prefix in the implemented concrete network
[ ] Translate "localhost" to actual IP when sending messages

Code inspection of classes in https://github.com/singnet/das-attention-broker/tree/e2317078084e3f26591878b68382d33b2ddef3ba/src/atom_space_node

September, 5 2024

AtomSpaceNode.{h,cc}
LeadershipBroker.{h,cc}
MessageBroker.{h,cc}
Message.{h,cc}

Inspectors: @levisingularity @marcocapozzoli @Pedrobc89 @angeloprobst @eddiebrissow

Pedrobc89 commented 1 month ago

I believe we are missing a timeout on the join_network method as well.

andre-senna commented 1 month ago

Regarding join_network:

As the node considers itself joined once the network has an elected leader, I think this doxygen should emphasize that and highlight that there is no validation or approval from a master node (or similar concept) or from the other nodes in the network.

Maybe this details should be in the implementation file (.cc) instead.

singnet / das

Code inspection AtomSpaceNode #99