sinkillerj / ProjectE

ProjectE. A complete rewrite of EE2 for modern Minecraft versions.
MIT License
406 stars 206 forks source link

Fully Featured EMC & Knowledge Subcommands #2245

Closed DonovanDMC closed 1 year ago

DonovanDMC commented 2 years ago

/projecte emc

/projecte knowlege

This is based on the /emc and /knowledge commands from Project Expansion. I've slightly modified them to better fit ProjectE. Primary differences:

I couldn't actually find the datagen task (I didn't really try that hard), so I'm unsure if I've actually added all that was needed (I've just added the strings to the en_us lang manually)

pupnewfster commented 2 years ago

Datagen task should just be runData. Which will also update the caches so that files don't have to be generated for other people who are running it in the future if nothing changes. It also updates en_ud automatically by running the datagen.

James103 commented 2 years ago

This should fix https://github.com/sinkillerj/ProjectE/issues/2024, as far as I can tell.

Also, will you please make sure that all instances of the term EMC are capitalized in the strings you add? Make sure to do this both in the generated lang file as well as the file that generates the lang file, and/or make sure to run the datagen task after changing the files. The rest of the strings have the EMC term capitalized.