Open DanKaplanSES opened 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
adcf936
) 96.02% compared to head (123df37
) 96.02%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I think this was mostly done, apart from a few tiny changes. Any chance you will get to complete this? Think it's less than 10 minutes of work.
@DanKaplanSES ? should I move it over the finish line?
@DanKaplanSES ? should I move it over the finish line?
Apologies, yeah I think that would be best; I don't fully understand what change you're suggesting.
Purpose (TL;DR) - mandatory
I kept scrolling past the parts of this page that explain
createStubInstance
so I created a section for it. I think the reason it didn't already exist is because it's considered a part of the utilities API, not the stub API. Even if that's the reasoning, I hope this PR is still a net positive, because personally, it makes it easier to find what I'm looking for.How to verify - mandatory
npm install
The documentation contribute in guide led me to believe that this doesn't apply to documentation changes. Let me know if I misinterpreted it, though.
Checklist for author
npm run lint
passes