search

sipcapture / hep-c

HEP: C implementation of HEP/EEP Encapsulation Protocol
http://sipcapture.org
Other
6 stars 5 forks source link

representing TLS and WSS transports in HEP #6

Open dpocock opened 8 years ago

dpocock commented 8 years ago

Looking at the patch adding HEP support to FreeSWITCH, it appears TLS and WSS are not really covered:

https://freeswitch.org/fisheye/rdiff/freeswitch?csid=981b528c48a44e0e775f6c8dec8e91ce9a01f252&u&N

+   /* PROTOCOL */
+   if(strcmp(self->tp_name->tpn_proto, "tcp") == 0) hg->ip_proto.data = IPPROTO_TCP;
+   else if(strcmp(self->tp_name->tpn_proto, "tls") == 0) hg->ip_proto.data = IPPROTO_IDP; /* FAKE*/
+   else if(strcmp(self->tp_name->tpn_proto, "sctp") == 0) hg->ip_proto.data = IPPROTO_SCTP;
+   else if(strcmp(self->tp_name->tpn_proto, "ws") == 0) hg->ip_proto.data = IPPROTO_TCP;
+   else if(strcmp(self->tp_name->tpn_proto, "wss") == 0) hg->ip_proto.data = IPPROTO_TCP;
+   else hg->ip_proto.data = IPPROTO_UDP; /* DEFAULT UDP */

Is that a limitation of HEP or is the FreeSWITCH implementation simply incomplete?

adubovikov commented 8 years ago

It was not compete, we will recheck it next week. Thank you for the pointers