sirchia / pimatic-rflink

RFLink plugin for Pimatic
GNU General Public License v2.0
3 stars 5 forks source link

Version working with node8 ? #19

Open akicker opened 5 years ago

akicker commented 5 years ago

Is a version working with node 8 in the queue ?

mwittig commented 5 years ago

Hi Riccardo, we're upgrading pimatic to to support newer Node.js versions. As part of this it'll be great if you can update your package to Serialport@6. Serialport@6 is not the very latest version, but it support Node.js version 4 to 10.

Some code changes will be required as the API of serialport has changed. Please have a look at the serialport driver we have implemented as part of Homeduinojs, for example. I am also happy to assist if you need help. BR, Marcus

https://github.com/pimatic/homeduinojs/blob/master/src/driver/serialport.coffee

akicker commented 5 years ago

Hi as my Development-System is running well based on raspbian buster, node10, ,... in my case, the only plugin missing is pimatic-rflink 👎 Unfortunately there is no feedback from Riccardo :-( Can anybody else help to migrate rflink to Serialport@6 (based on node 8 or 10) ???

nona00 commented 2 years ago

Hello,

In the past I retarded upgrades to Node.js because of this issue.

Now I decided to do a quick migration of rflink by myself to Serialport@6 based on the comment of @mwittig .

My patch works for me on pi3, raspbian buster, node v10.24.0

applying the patch: cd pimatic-app cd node_modules git clone https://github.com/sirchia/pimatic-rflink cd pimatic-rflink patch -p1 < pimatic-rflink_nodejs10_patch.txt

pimatic-rflink_nodejs10_patch.txt